sorry, don't have time to review the pr, hope another maintainer could do it

I'm quite pleased. We now:

1. have our completely independent <storagePath>/.ghcup prefix where we manage HLS versions
2. we can easily remove old versions, update etc.
3. we could theoretically use this to pre-install cabal/ghc/stack as well

For the future, the extension could also have an option for the user to use the system-installed ghcup. But this really needs to be behind a config option imo.

For the future, the extension could also have an option for the user to use the system-installed ghcup. But this really needs to be behind a config option imo.

I am interested in that, and I agree, it should be hidden behind a config option.

Some tests are failing, probably because we started messing with process.env:

2 failing

  1) Extension Test Suite
       Extension log should have server output:
     AssertionError [ERR_ASSERTION]: Extension log file has no hls output
  	at /home/runner/work/vscode-haskell/vscode-haskell/out/test/suite/extension.test.js:136:16
  	at Generator.next (<anonymous>)
  	at fulfilled (out/test/suite/extension.test.js:5:58)


  2) Extension Test Suite
       Server should inherit environment variables defined in the settings:

      AssertionError [ERR_ASSERTION]: Server did not inherit XDG_CACHE_DIR from environment variables set in the settings
      + expected - actual

      -false
      +true
      
  	at /home/runner/work/vscode-haskell/vscode-haskell/out/test/suite/extension.test.js:140:16
  	at Generator.next (<anonymous>)
  	at fulfilled (out/test/suite/extension.test.js:5:58)

Ideas?

I'm assuming the extension used to try to find older HLS releases if the current project GHC is too old?

I'm assuming the extension used to try to find older HLS releases if the current project GHC is too old?

Yes, and this was a highly requested feature that we should definitely not break.

I'm assuming the extension used to try to find older HLS releases if the current project GHC is too old?

Yes, and this was a highly requested feature that we should definitely not break.

This is fixed in cda68ba

Example:

I don't understand why the tests are failing. I hope someone else can pick that up, because I'm running out of free time for this.

Well, I'm giving up on the test suite. It works locally. That's enough for me.

Ill take a look